Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add use_scalar_weights argument #3189

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Add use_scalar_weights argument #3189

merged 6 commits into from
Nov 21, 2022

Conversation

tkoyama010
Copy link
Member

Overview

Add use_scalar_weights argument

resolves #3188

Details

  • @p-j-smith I made a draft PR. Could you test this branch that it works for you?

@github-actions github-actions bot added the enhancement Changes that enhance the library label Aug 20, 2022
@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #3189 (6aa2cc7) into main (a14bb77) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3189   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          83       83           
  Lines       18634    18636    +2     
=======================================
+ Hits        17734    17736    +2     
  Misses        900      900           

tests/test_polydata.py Outdated Show resolved Hide resolved
@p-j-smith
Copy link
Contributor

Thank you for drafting this so quickly @tkoyama010! It works locally with python=3.9 and vtk=9.1

@tkoyama010 tkoyama010 marked this pull request as ready for review November 15, 2022 21:17
banesullivan
banesullivan previously approved these changes Nov 16, 2022
@tkoyama010 tkoyama010 merged commit 78f2a82 into main Nov 21, 2022
@tkoyama010 tkoyama010 deleted the feat/scalar_weights branch November 21, 2022 19:53
adeak added a commit to adeak/pyvista that referenced this pull request Nov 22, 2022
* upstream/main:
  Fix test names (pyvista#3631)
  Add use_scalar_weights argument (pyvista#3189)
  Clarify that interpolate only maps point data to point data (pyvista#3621)
  Bump awalsh128/cache-apt-pkgs-action from 1.1.2 to 1.1.3 (pyvista#3630)
  Update hypothesis requirement from <6.57.2 to <6.58.1 (pyvista#3629)
  Move project metadata to pyproject.toml; avoid calling setup.py (pyvista#3619)
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weight geodesic calculations by edge length
5 participants