Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize warnings #3232

Merged
merged 5 commits into from
Nov 16, 2022
Merged

Standardize warnings #3232

merged 5 commits into from
Nov 16, 2022

Conversation

banesullivan
Copy link
Member

resolves #838

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited

Codecov Report

Merging #3232 (b261b08) into main (b99e5f8) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
- Coverage   95.17%   95.17%   -0.01%     
==========================================
  Files          83       83              
  Lines       18571    18555      -16     
==========================================
- Hits        17675    17659      -16     
  Misses        896      896

MatthewFlamm
MatthewFlamm reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm +1, in general, on these changes.

pyvista/core/filters/poly_data.py Outdated Show resolved Hide resolved
pyvista/utilities/helpers.py Outdated Show resolved Hide resolved
@banesullivan
Copy link
Member Author

I think this PR is ready to go. I did notice that logger.warning is still used in pyvista/ext/coverage.py though... I feel like that module can be an exception but what are your thoughts, @pyvista/developers ?

@banesullivan banesullivan marked this pull request as ready for review November 10, 2022 21:43
@banesullivan
Copy link
Member Author

Merging this

@banesullivan banesullivan merged commit 73e8eb9 into main Nov 16, 2022
@banesullivan banesullivan deleted the maint/warnings branch November 16, 2022 03:29
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adeak adeak adeak left review comments

@MatthewFlamm MatthewFlamm MatthewFlamm left review comments

Assignees
No one assigned
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize warnings
3 participants
@banesullivan @adeak @MatthewFlamm