Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve main landing page #3459

Merged
merged 2 commits into from Oct 14, 2022
Merged

Improve main landing page #3459

merged 2 commits into from Oct 14, 2022

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented Oct 13, 2022

Remove the logo being executed on the main page with a static image, add an "overview" section, and use panel instead of pythreejs as pythreejs doesn't center properly.

While I really liked the logo "executing" at the top of the page, having content move around while assets lazily load seems like a bad practice. Plus, we repeated the logo viz elsewhere in the docs, so this is repeated content.

Here's the new rendered page.

tmp

Continued...

tmp2

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3459 (d0ec3e8) into main (20cd017) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3459   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          83       83           
  Lines       18533    18533           
=======================================
  Hits        17638    17638           
  Misses        895      895           

@akaszynski akaszynski merged commit b2fe8b8 into main Oct 14, 2022
@akaszynski akaszynski deleted the docs/final_cleanup branch October 14, 2022 00:11
@akaszynski akaszynski mentioned this pull request Nov 1, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website Hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants