Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements-txt-fixer to .pre-commit-config.yaml #3541

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Nov 2, 2022

Overview

I often forget to sort names when adding packages to the requirements file.
Adding requirements-txt-fixer option in .pre-commit-config.yaml prevents this human error.

Details

  • None

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Nov 2, 2022
@tkoyama010 tkoyama010 marked this pull request as ready for review November 2, 2022 12:43
@tkoyama010 tkoyama010 changed the title Add requirements-txt-fixer to requirements-txt-fixer Add requirements-txt-fixer to .pre-commit-config.yaml Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3541 (a1a49bf) into main (a9d2186) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3541   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          83       83           
  Lines       18571    18571           
=======================================
  Hits        17674    17674           
  Misses        897      897           

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Great idea.

Automate everything!

@tkoyama010 tkoyama010 merged commit dbce440 into main Nov 3, 2022
@tkoyama010 tkoyama010 deleted the maint/add-requirements-txt-fixer branch November 3, 2022 10:18
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants