Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default points_gaussian representation #3559

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

akaszynski
Copy link
Member

This PR changes the default points_gaussian to use render_points_as_spheres=False. This is a bit more of a sensible default as emissive=False by default and it has no issues rendering on a white background.

Also moves colors.rst into a new directory and renames it to colors_table as sphinx was complaining about a recursive include locally despite clean builds. I'm not sure why it's not occuring in our builds, but I'd like to make sure this issue doesn't occur for others.

@github-actions github-actions bot added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. labels Nov 5, 2022
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Merging #3559 (0f52ea8) into main (e39c129) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3559   +/-   ##
=======================================
  Coverage   95.16%   95.17%           
=======================================
  Files          83       83           
  Lines       18571    18571           
=======================================
+ Hits        17674    17675    +1     
+ Misses        897      896    -1     

@akaszynski akaszynski added this to the v0.37.1 milestone Nov 6, 2022
@akaszynski akaszynski merged commit ecd1dc6 into main Nov 9, 2022
@akaszynski akaszynski deleted the fix/gaussian-points-rep branch November 9, 2022 17:36
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants