Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version check for mpl #3583

Merged
merged 1 commit into from
Nov 13, 2022
Merged

add version check for mpl #3583

merged 1 commit into from
Nov 13, 2022

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented Nov 10, 2022

With

from matplotlib import colormaps, colors

In pyvista/plotting/colors.py if matplotlib<3.5.0 we get an ImportError. Since we don't specify a minimum version for matplotlib since it's not a direct dependency, and neither does vtk, we can either try to make our imports backwards compatible or just complain about a minimum supported version.

Since 3.5.0 was out around a year ago, I think it's safe to simply require it, even though it seems a little restrictive. We can implement a follow-up PR with some additional logic if we deem it necessary. For now, this is a improvement over the current implementation.

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Nov 10, 2022
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #3583 (8d209b6) into main (b99e5f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3583   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          83       83           
  Lines       18571    18572    +1     
=======================================
+ Hits        17675    17676    +1     
  Misses        896      896           

@tkoyama010 tkoyama010 merged commit 1ed26bd into main Nov 13, 2022
@tkoyama010 tkoyama010 deleted the fix/mpl-ver branch November 13, 2022 01:31
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants