Finalize v0.37 deprecations #3602
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3602 +/- ##
==========================================
- Coverage 95.17% 95.13% -0.05%
==========================================
Files 83 83
Lines 18579 18489 -90
==========================================
- Hits 17683 17589 -94
- Misses 896 900 +4 |
There was a problem hiding this comment.
This should probably be merged after #3601, since that one targets main branch and this one removes the fixed code entirely.
| @property | ||
| def active_texture_name(self) -> Optional[str]: # pragma: no cover | ||
| """Name of the active texture coordinates array. | ||
|
|
||
| .. deprecated:: 0.32.0 | ||
| Use :attr:`DataSetAttributes.active_t_coords_name` to | ||
| return the name of the active texture coordinates array. | ||
|
|
||
| """ | ||
| warnings.warn( | ||
| "Use of `active_texture_name` is deprecated. Use `active_t_coords_name` instead.", | ||
| PyVistaDeprecationWarning, | ||
| ) | ||
| return self.active_t_coords_name |
There was a problem hiding this comment.
I want to point out that is was not supposed to be deprecated... active_texture_name is not equivalent to active_t_coords_name. active_texture_name refers to a PyVista-specific feature I implemented a few years ago that tracks actual Texture objects so that if you have an "active texture" that add_mesh would pick up on it and render it automatically. This has no equivalent in VTK, so I'm fine with it now being broken/not supported, but we may want to clean all of this up in a new PR as the _textures property this is supposed to control still exists.
cc @pyvista/developers
This finalizes many deprecations that were targeted for v0.37 (which has already released). IMO, all of these are safe to remove at this point.
For any remaining deprecations, I made sure to add a note of planned removal; most targeting v0.40