Add support to modulate the tube filter's radius in absolute units #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added absolute argument to turn this on, the detault behaviour modulating the radius relatively is left unchanged - Added an example to the spline section, however this works just as well with any line mesh
github-actions
bot
added
the
documentation
jmargeta
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3649 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 83 83
Lines 18556 18558 +2
=======================================
+ Hits 17652 17654 +2
Misses 904 904 |
tkoyama010
requested changes
Nov 27, 2022
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com>
|
Thanks a lot for the speedy review, @tkoyama010 ! |
adeak
reviewed
Nov 27, 2022
tkoyama010
previously approved these changes
Nov 27, 2022
adeak
reviewed
Nov 27, 2022
tkoyama010
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an argument to the tube filter so that the radius can be specified in absolute units for convenience.
Internally, it uses the SetVaryRadiusToVaryRadiusByAbsoluteScalar of vtkTubeFilter.
Details