Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a test of KochanekSpline. #3657

Merged
merged 11 commits into from
Dec 14, 2022
Merged

Fix a test of KochanekSpline. #3657

merged 11 commits into from
Dec 14, 2022

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Nov 28, 2022 •
edited

Overview

Fix the docstring format in KochanekSpline.

Details

  • None

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Nov 28, 2022
tkoyama010
tkoyama010 commented Nov 28, 2022
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@tkoyama010 tkoyama010 marked this pull request as ready for review November 28, 2022 22:34
@codecov
Copy link

codecov bot commented Nov 28, 2022 •
edited

Codecov Report

Merging #3657 (dfacfea) into main (31c4b5f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3657   +/-   ##
=======================================
  Coverage   94.07%   94.08%           
=======================================
  Files          83       83           
  Lines       18618    18618           
=======================================
+ Hits        17515    17516    +1     
+ Misses       1103     1102    -1

@tkoyama010 tkoyama010 changed the title Fix the default n_points value in KochanekSpline. Fix the docstring format in KochanekSpline. Dec 4, 2022
@tkoyama010 tkoyama010 changed the title Fix the docstring format in KochanekSpline. Fix the docstring format and test in KochanekSpline. Dec 4, 2022
@tkoyama010 tkoyama010 added maintenance Low-impact maintenance activity and removed bug Uh-oh! Something isn't working as expected. labels Dec 4, 2022
banesullivan
banesullivan previously approved these changes Dec 12, 2022
View reviewed changes
@banesullivan
Copy link
Member

@tkoyama010, I believe this had conflicts with #3678... Could you resolve these?

@banesullivan banesullivan self-requested a review December 13, 2022 16:10
@banesullivan banesullivan marked this pull request as draft December 13, 2022 16:37
@tkoyama010 tkoyama010 changed the title Fix the docstring format and test in KochanekSpline. Fix a test of KochanekSpline. Dec 14, 2022
@tkoyama010 tkoyama010 marked this pull request as ready for review December 14, 2022 09:00
@banesullivan banesullivan merged commit 328a8e0 into main Dec 14, 2022
@banesullivan banesullivan deleted the fix/kochanekspline branch December 14, 2022 15:03
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banesullivan banesullivan banesullivan approved these changes

Assignees
No one assigned
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tkoyama010 @banesullivan