Remove progressbar from pooch fetch and downloads API

[adeak]

As pointed out in a question on Stack Overflow, PyVista breaks on anything older than the currently newest pooch (1.6.0, released in January 2022).

Removing the progressbar kwarg from the call to fetch() makes us compatible with pooch 1.3.0 the oldest, which was released 2 years ago. 1.3.0 added the retry_if_failed feature, which is something we should keep, so this should be an acceptable compromise.

This is a minor breaking change if anyone downstream used the progress_bar kwarg of downloads.

[tkoyama010]

Thanks for this.

[adeak]

Almost forgot to remove the functionality from the downloads API 😅

[codecov]

Codecov Report

Merging #3693 (3710e3a) into main (f5dbce8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3693   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          83       83           
  Lines       18558    18558           
=======================================
  Hits        17454    17454           
  Misses       1104     1104           

[banesullivan]

I'm happy with this as is and don't think we need to catch/deprecate the user's use of progress_bar argument

[banesullivan]

Thanks, @adeak!!

[adeak]

I'm happy with this as is and don't think we need to catch/deprecate the user's use of progress_bar argument

Good point; let me label this as a breaking change though.