Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement widget that snaps to points #3718

Merged
merged 14 commits into from
Jun 29, 2023
Merged

Conversation

banesullivan
Copy link
Member

Opening a draft PR for @chadqueen's work based the solutions in #588 (resolves #588)

This adds a measurement widget that snaps to points of a mesh utilizing picking. Needs work

@banesullivan banesullivan self-assigned this Dec 16, 2022
@github-actions github-actions bot added documentation Anything related to the documentation/website enhancement Changes that enhance the library labels Dec 16, 2022
@banesullivan banesullivan changed the title Add measurement widget that snaps to points [WIP] Add measurement widget that snaps to points Dec 16, 2022
@banesullivan banesullivan added this to the v0.39 milestone Jan 29, 2023
@banesullivan banesullivan changed the title [WIP] Add measurement widget that snaps to points Measurement widget that snaps to points Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #3718 (a1d73c0) into main (54e75aa) will increase coverage by 0.00%.
The diff coverage is 97.67%.

@@           Coverage Diff           @@
##             main    #3718   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         127      127           
  Lines       21351    21395   +44     
=======================================
+ Hits        20448    20491   +43     
- Misses        903      904    +1     

@banesullivan banesullivan marked this pull request as ready for review June 29, 2023 01:12
@banesullivan banesullivan merged commit 12fccc1 into main Jun 29, 2023
25 checks passed
@banesullivan banesullivan deleted the feat/measure_widget branch June 29, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Measurement widget snaps to points on mesh
3 participants