Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two other closed geometric objects. #3723

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

dcbr
Copy link
Contributor

@dcbr dcbr commented Dec 18, 2022

Overview

As per my comment in #3710, there are two other closed geometric objects that require a fix in my opinion.

Details

Ellipse
pyvista.Ellipse(resolution=4).plot()
Before After
image image

Duplicate endpoints and inconsistent edge lengths; similar fix as in #3710.

CylinderStructured
pyvista.CylinderStructured(theta_resolution=4).plot()
Before After
image image

Inconsistent number of edges/faces when compared to Cylinder; as this is a StructuredGrid duplicate endpoints are needed in this case I believe (correct me if I'm wrong), so the fix is different than for the Ellipse above.

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Dec 18, 2022
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #3723 (872fe98) into main (9191366) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3723   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          83       83           
  Lines       18641    18641           
=======================================
  Hits        17530    17530           
  Misses       1111     1111           

Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing these and adding the versionchanged note. I'm going to add the "breaking-change" label to the PR so this gets picked up in the release notes

@banesullivan banesullivan added the breaking-change Changes that break backwards compatibility, especially changed default parameters. label Dec 19, 2022
@banesullivan banesullivan merged commit 6489ed6 into pyvista:main Dec 19, 2022
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
@dcbr dcbr deleted the fix/closed_geometrics branch February 2, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that break backwards compatibility, especially changed default parameters. bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants