-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix builds #3740
Merged
Merged
Fix builds #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3740 +/- ##
==========================================
- Coverage 94.02% 93.99% -0.03%
==========================================
Files 82 82
Lines 18545 18553 +8
==========================================
+ Hits 17437 17439 +2
- Misses 1108 1114 +6 |
akaszynski
commented
Dec 22, 2022
banesullivan
approved these changes
Dec 23, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix our builds with:
ubuntu-22.04
toubuntu-20.04
. The slowdown could be for any number of reasons, but I'm guessing it's due to the increased render time by upgrading fromMesa 21.2.6
toMesa 22.0.5
pyvista_ndarray
tovtkPoints
withpyvista.vtk_points
that only seems to show up on Python 3.11 (.LinuxConda
build)More details about the memory leak
When
vtk_points
is provided with apyvista_ndarray
anddeep=False
, VTK retails a reference to thepyvista_ndarray
withinnumpy_to_vtk
. Sincepyvista_ndarray
contains a reference to thevtkDataArray
, this results in a circular reference since thevtkDataArray
is also referenced by the newvtkDataArray
contained in the newvtkPoints
object.One way to work around this is to simply set the new
vtk.vtkPoints
's data to point to the data referred to by thepyvista_ndarray
. This way VTK can track references and wif thepyvista_ndarray
is deallocated there will still be a reference to the underlying data. However, this doesn't work with strides because (as far as I can tell) VTK doesn't support strides the same way thatnumpy
does. I could WriteVoidPointer, but we would be back at the same place we'd started since void pointers are just that, pointers to a space in memory rather than an object with reference counting.Voting for get this merged soon since bad builds mean sad developers.