Fix dataobject repr #3786
Merged
Fix dataobject repr #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3786 +/- ##
=======================================
Coverage 94.08% 94.09%
=======================================
Files 83 83
Lines 18679 18686 +7
=======================================
+ Hits 17575 17582 +7
Misses 1104 1104 |
banesullivan
approved these changes
Jan 6, 2023
larsoner
added a commit
to larsoner/pyvista
that referenced
this pull request
Jan 6, 2023
* upstream/main: Add color cyclers for `add_mesh(..., color=True)` (pyvista#3739) fix dataobject repr (pyvista#3786)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix: use spaces rather than tabs in our
__repr__forpyvista.DataObject.Reasoning: When copying the
__repr__, the tabs are often shifted by too little or two much and have to be manually converted when copying them into examples. Using spaces alleviates this issue, and follows PEP8's recommendation:I think that this should be applied to
__repr__as well, and since we should avoid mixing tabs and spaces, this PR proposes to just go with spaces.