Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test MathText for conda CI #3795

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Test MathText for conda CI #3795

merged 2 commits into from
Jan 10, 2023

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Jan 9, 2023

Follow up to #3781

FYI conda-forge/vtk-feedstock#79

The VTK feedstock just bumped to 9.2.5 and thus no longer matplotlib<3.6 for MathText/LaTeX symbol rendering.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity labels Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #3795 (477b88e) into main (4b3a856) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3795      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.02%     
==========================================
  Files          86       86              
  Lines       18891    18899       +8     
==========================================
+ Hits        17787    17800      +13     
+ Misses       1104     1099       -5     

@banesullivan
Copy link
Member Author

tests/plotting/test_plotting.py::test_add_text_latex PASSED              [ 72%]

Test is now passing for conda CI, good to merge

@Tobias-Fischer
Copy link

If you want to wait a little bit, I just merged in vtk 9.2.5 for conda-forge

@banesullivan
Copy link
Member Author

@Tobias-Fischer, oh awesome!! Super awesome that update was seemingly painless! I will wait and unlimit MPL in this PR

@banesullivan banesullivan marked this pull request as draft January 9, 2023 03:24
environment.yml Outdated Show resolved Hide resolved
@banesullivan banesullivan changed the title Limit matplotlib<3.6 for Conda CI Test MathText for conda CI Jan 9, 2023
@banesullivan banesullivan marked this pull request as ready for review January 10, 2023 14:48
@banesullivan banesullivan merged commit 4fe5620 into main Jan 10, 2023
@banesullivan banesullivan deleted the maint/conda-vtk-mathtext branch January 10, 2023 21:18
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants