Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc build encoding issue #3814

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Fix doc build encoding issue #3814

merged 1 commit into from
Jan 12, 2023

Conversation

dcbr
Copy link
Contributor

@dcbr dcbr commented Jan 11, 2023

Overview

When doing a clean build of the documentation on Windows 10, I needed these changes to the file writing encoding for the build to succeed.

@github-actions github-actions bot added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. labels Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #3814 (7b0c54d) into main (3eaf721) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3814   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files          86       86           
  Lines       18914    18914           
=======================================
  Hits        17815    17815           
  Misses       1099     1099           

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@banesullivan banesullivan merged commit 880d172 into main Jan 12, 2023
@banesullivan banesullivan deleted the fix/doc_encoding branch January 12, 2023 17:17
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants