Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve silhouette decimate parameter check #3817

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

banesullivan
Copy link
Member

Ref #3318 (comment)

@adeak:

I know this was here before, but is it not weird to test for floatness? Shouldn't we be testing for not Noneness instead? Or am I missing the point here? If someone passes an int by mistake, we won't raise.

I changed this to check truthy-ness

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Jan 12, 2023
pyvista/plotting/plotting.py Show resolved Hide resolved
@banesullivan banesullivan merged commit bc306a0 into main Jan 12, 2023
@banesullivan banesullivan deleted the maint/silhouette_decimate branch January 12, 2023 17:17
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants