Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
'smart'
mapper chooses one of the other available mappers based on rendering parameters and available hardware. I added some notes on how that decision is made.I also added a waring about the
fixed_point
mapper and how it CPU-basedAddition notes not included in docs
I noticed on my machine today that when datasets have
NaN
values, the'fixed_point'
mapper might work best, but the'smart'
mapper was choosing something different. I added these notes to the docstring to help others. I do not want to change the default behavior as the'smart'
mapper usually chooses the best mapper for the given hardware and autoselecting'fixed_point'
in the presence ofNaN
values could fail for some hardware.I'm seeing this issue on my M2 Mac but not my Linux machine with an NVIDIA graphics card