Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a recompute_normals parameter to PolyData.save #3845

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Add a recompute_normals parameter to PolyData.save #3845

merged 3 commits into from
Jan 20, 2023

Conversation

lverret
Copy link
Contributor

@lverret lverret commented Jan 19, 2023

Overview

resolves #3844

Details

  • Add a recompute_normals parameter to the PolyData.save method
  • Update documentation for recompute_normals

@github-actions github-actions bot added the enhancement Changes that enhance the library label Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023 •
edited

Codecov Report

Merging #3845 (1c75867) into main (6b64049) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1c75867 differs from pull request most recent head c5929e5. Consider uploading reports for the commit c5929e5 to get more accurate results

@@           Coverage Diff           @@
##             main    #3845   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files          87       87           
  Lines       19111    19111           
=======================================
  Hits        17991    17991           
  Misses       1120     1120

akaszynski
akaszynski approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@banesullivan banesullivan merged commit fc217c3 into pyvista:main Jan 20, 2023
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski approved these changes

@banesullivan banesullivan banesullivan approved these changes

Assignees
No one assigned
Labels
enhancement Changes that enhance the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PolyData.save: Add a recompute_normals parameter when saving STL/PLY meshes
3 participants
@lverret @akaszynski @banesullivan