-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track Actor names better and improve add_actor #3864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banesullivan
changed the title
Track Actor names
Track Actor names better and improve add_actor
Jan 23, 2023
banesullivan
commented
Jan 23, 2023
banesullivan
commented
Jan 23, 2023
Codecov Report
@@ Coverage Diff @@
## main #3864 +/- ##
==========================================
- Coverage 94.18% 94.18% -0.01%
==========================================
Files 87 87
Lines 19156 19179 +23
==========================================
+ Hits 18043 18064 +21
- Misses 1113 1115 +2 |
akaszynski
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the changes. Thanks!
This was referenced Feb 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyVista's
BasePlotter
tracks allActor
s added to the scene with a unique name. This is a widely used feature and is tested quite well. Prior to this PR, theActor
s themselves are unaware of their names, and I think PyVista'sActor
class should track this value.I don't like to add attributes that do not map to existing attributes/properties that exist in VTK, but in my opinion, this is a valid exception for a feature we've implemented specifically for PyVista.
Additionally, this adds support for explicit exceptions when using the
@no_new_attr
decorator._renderer
was a class attribute onActor
previous to this and I don't think it was actually working as expected. Through the use of_new_attr_exceptions
, now classes can have a few explicit exceptions for new instance attributes like_renderer
and_name
forActor