Fix a few issues with Plotter.show

[banesullivan]

Fix a few issues with Plotter.show()

Resolves #1635, Resolves #3548, Resolves #2953, Resolves #1877, Resolves #1665, Resolves #1621

Some cleanups to improve the return values of Plotter.show() so that if return_* is set, the requested item will always be returned.

Further, this removes the store_image property as the whole point of last_image was always to have an image after rendering. I probably need to deprecate this instead of outright removing...

@akaszynski and @pyvista/developers, I would appreciate a thorough review on this one as changing up the show() method nearly always has unexpected consequences

[codecov]

Codecov Report

Merging #3889 (a1002b6) into main (23ba481) will increase coverage by 0.02%.
The diff coverage is 94.59%.

@@            Coverage Diff             @@
##             main    #3889      +/-   ##
==========================================
+ Coverage   94.16%   94.19%   +0.02%     
==========================================
  Files          91       91              
  Lines       19586    19566      -20     
==========================================
- Hits        18444    18431      -13     
+ Misses       1142     1135       -7     

[banesullivan]

There is a very odd image regression failure showing up here... hoping that #3891 resolves it

[akaszynski]

A few minor changes, otherwise LGTM.

Since we're maintaining backwards compatibility as much as possible, I agree with the changes here and appreciate removing store_image. It always felt like a hack.

[banesullivan]

Thanks! Merging after CI turns green and will sync #3897