Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3d text actors by default #3910

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Use 3d text actors by default #3910

merged 2 commits into from
Jan 31, 2023

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented Jan 31, 2023

Resolve #3908 by using 3d text actors by default.

This also has the side effect of improving the smoothness of the fonts and improving the overall quality of the text actors.

import pyvista as pv
pv.set_plot_theme('document')
mesh = pv.Sphere()
pl = pv.Plotter(shape=(1, 2))
pl.add_mesh(mesh)
pl.add_text('use_3d_text=False')
pl.show_bounds(
    grid='front',
    location='outer',
    all_edges=True,
    use_3d_text=False,
    bold=False,
    font_size=16,
)
pl.subplot(0, 1)
pl.add_mesh(mesh)
pl.add_text('use_3d_text=True')
pl.show_bounds(
    grid='front',
    location='outer',
    bold=False,
    all_edges=True,
    font_size=16,
    use_3d_text=True,
)

pl.show()

tmp

@akaszynski akaszynski changed the title use 3d text actors by default Use 3d text actors by default Jan 31, 2023
@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #3910 (69a4889) into main (8698af5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3910      +/-   ##
==========================================
+ Coverage   94.20%   94.21%   +0.01%     
==========================================
  Files          91       91              
  Lines       19625    19697      +72     
==========================================
+ Hits        18487    18558      +71     
- Misses       1138     1139       +1     

banesullivan
banesullivan previously approved these changes Jan 31, 2023
Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Agree with the default change since set_scale() is plagued with other issues and should justify a poorer default choice

@banesullivan banesullivan merged commit eac9ab2 into main Jan 31, 2023
@banesullivan banesullivan deleted the fix/use-3d-text-default branch January 31, 2023 13:57
@banesullivan banesullivan mentioned this pull request Feb 1, 2023
5 tasks
@tkoyama010 tkoyama010 added the breaking-change Changes that break backwards compatibility, especially changed default parameters. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes that break backwards compatibility, especially changed default parameters. bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to change font type in renderer.show_bounds
3 participants