Test with Python 3.11 #3944
Merged
Test with Python 3.11 #3944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banesullivan
commented
Feb 2, 2023
banesullivan
commented
Feb 2, 2023
Comment on lines
-177
to
-186
| - name: Publish notebooks on main | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | ||
| uses: peaceiris/actions-gh-pages@v3 | ||
| with: | ||
| external_repository: pyvista/pyvista-examples | ||
| personal_token: ${{ secrets.PYVISTA_BOT_TOKEN }} | ||
| publish_dir: pyvista-examples | ||
| publish_branch: develop | ||
| exclude_assets: '' | ||
| force_orphan: true |
There was a problem hiding this comment.
These are pushing to the same repo as the release and thus overwriting the examples from the release. The docker image there uses the latest tag so it's very likely that the examples will mismatch the PyVista version there
Codecov Report
@@ Coverage Diff @@
## main #3944 +/- ##
=======================================
Coverage 94.30% 94.30%
=======================================
Files 94 94
Lines 20321 20321
=======================================
Hits 19163 19163
Misses 1158 1158 |
|
There are pending status checks because some of these are set as required in the repo settings. If this merges, I will update the required checks to the new jobs added here |
akaszynski
approved these changes
Feb 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mwtoews, this handles adding Python 3.11 to CI to supersede some of your changes in #3938
Adds CI testing for Python 3.11 and attempts to speed up the docs build with 3.11