Speed up PVDReader for files with many time points #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3946 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 97 97
Lines 20608 20611 +3
Branches 3480 3481 +1
=======================================
+ Hits 19478 19481 +3
Misses 1129 1129
Partials 1 1 |
akaszynski
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Sorry for the delayed review @MatthewFlamm, I'll get better about reviewing these.
LGTM. Didn't even see the GIF there in the docstr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes #3937. Adds in a mapping with keys of time that stores datasets. This extremely reduces the time required to iterate over a PVDfile with many time points.