Fix Plotter docs #3968
Merged
Fix Plotter docs #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #3968 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 94 94
Lines 20214 20214
=======================================
Hits 19317 19317
Misses 897 897 |
|
Should we add a check for broken intersphinx links? These are hard to catch manually. |
|
I'd like to have this merged today for our 0.38.4 release. As this doesn't change the API and really improves the docs, a cursory review would be appreciated but I'll press without it and beg for forgiveness. |
|
Alright, except for a few exceptions, fixed all the intersphinx and role links. |
akaszynski
pushed a commit
that referenced
this pull request
Mar 10, 2023
Merged
akaszynski
added a commit
that referenced
this pull request
Mar 11, 2023
* bump to 0.38.4 * update req in earnest * fix plotter reopening (#4102) * Update testing-and-deployment.yml * Update requirements_test.txt Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> * Update testing-and-deployment.yml * Apply suggestions from code review * Change source links to github (#4113) * add linkcode * Update pyvista/utilities/docs.py Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> --------- Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> * Fix Plotter docs (#3968) --------- Co-authored-by: MatthewFlamm <39341281+MatthewFlamm@users.noreply.github.com> Co-authored-by: Tetsuo Koyama <tkoyama010@gmail.com> Co-authored-by: Bane Sullivan <bane.sullivan@kitware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to resolveResolves #3956 and #4023