[HOTFIX] Propagate Trame UI controls to all views #3983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The camera controls are a different beast to deal with for this. Would like to merge as is and address camera controls laters for non-linked views |
|
Going to merge as a hotfix and backport to |
Codecov Report
@@ Coverage Diff @@
## main #3983 +/- ##
==========================================
- Coverage 94.30% 94.29% -0.01%
==========================================
Files 94 94
Lines 20323 20330 +7
==========================================
+ Hits 19165 19171 +6
- Misses 1158 1159 +1 |
banesullivan
changed the title
banesullivan
changed the title
banesullivan
added a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue raised in #3982 cc @giiyms
The UI controls for the Trame view would only control the current active renderer. I think it makes sense for the controls to propagate to all renderers.
Screen.Recording.2023-02-08.at.10.41.23.AM.mov