Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI state defaults #3993

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Improve UI state defaults #3993

merged 1 commit into from
Feb 9, 2023

Conversation

banesullivan
Copy link
Member

This improves the default state of the Trame UI so that if one of the options is already enabled, the UI initialization with mostly reflect that

backporting to release/0.38

@github-actions github-actions bot added the bug Uh-oh! Something isn't working as expected. label Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Merging #3993 (4451362) into main (3bd7b94) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3993   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          97       97           
  Lines       20587    20587           
  Branches     3477     3477           
=======================================
  Hits        19457    19457           
  Misses       1129     1129           
  Partials        1        1           

@banesullivan banesullivan merged commit c054d3b into main Feb 9, 2023
@banesullivan banesullivan deleted the patch/trame-ui-defaults branch February 9, 2023 21:12
banesullivan added a commit that referenced this pull request Feb 9, 2023
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants