-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set VTK 9.0 as the minimum supported version #4018
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4018 +/- ##
==========================================
+ Coverage 94.51% 94.52% +0.01%
==========================================
Files 97 97
Lines 20609 20464 -145
Branches 3480 3430 -50
==========================================
- Hits 19478 19344 -134
+ Misses 1130 1119 -11
Partials 1 1 |
e8816ec
to
2b3a6ab
Compare
I started pyvista/pytest-pyvista#44 to enable this PR. |
This is fantastic and I am eager to merge this when everyone is on board! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments to get started.
This PR will be increasingly hard to maintain as other PRs are merged. I recommend merging soon if agreed upon. I made pyvista/pytest-pyvista#47 for a release then this PR can be finalized. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go. Thanks @mwtoews.
Let's merge this soon to avoid any potential merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A forward looking thought: I'm not sure whether it would be now better to from vtkmodules import ...
where it is used. _vtk
now mostly just flattens vtkmodules
.
This is a great point. One issue we've had is that we load everything all upfront despite not using all libraries. If we instead "lazy load" everything, we can improve load time and memory footprint. |
Overview
As discussed in #3938 this PR removes pre-VTK 9 logic, setting VTK 9.0 as the minimum supported version.
Details
pyvista/_vtk.py
are difficult to see due the change of indent level, but are relatively minorpyvista._vtk.VTK9
for now, as this is used externally by pytest-pyvista; removepyvista._vtk.VTK91
which had limited usegenerate_cell_offsets_loop()
andgenerate_cell_offsets()
, which were only used for pre-VTK9UnstructuredGrid()
with four argumentscan_process_events
property and other variables likeVERY_FIRST_RENDER
andupdate_timer_id
needs_vtk9
pytest marker