Close all plotters in testing, bump pytest-pyvista

[MatthewFlamm]

Overview

Attempt to resolve problems in pyvista/pytest-pyvista#51 and #4103

This PR also includes version bump for pytest-pyvista to prevent leaking scope for verify_image_cache which can happen when a plotter is closed after a failed test.

[codecov]

Codecov Report

Merging #4114 (cdedba7) into main (7f5d36b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4114      +/-   ##
==========================================
+ Coverage   95.56%   95.57%   +0.01%     
==========================================
  Files          94       95       +1     
  Lines       20213    20292      +79     
==========================================
+ Hits        19316    19394      +78     
- Misses        897      898       +1     

[akaszynski]

LGTM. Thanks!

[MatthewFlamm]

In testing over in pytest-pyvista, the changes here make things worse if we do not also include the changes from pyvista/pytest-pyvista#51. See pyvista/pytest-pyvista#49 for comparison

[akaszynski]

In testing over in pytest-pyvista, the changes here make things worse if we do not also include the changes from pyvista/pytest-pyvista#51. See pyvista/pytest-pyvista#49 for comparison

Do we need another release of pytest-pyvista before merging this?

[MatthewFlamm]

Do we need another release of pytest-pyvista before merging this?

Sorry for not being very clear or prescriptive. I would recommend waiting on this one until we can merge in a version bump soon after. This one alone makes the errors even worse, presumably due to not cleaning up well enough in the other package.

I'm not sure if we should fix the image regressions in the other package first, or separate out the downstream testing piece and merge in the guards first.

[MatthewFlamm]

pyvista/pytest-pyvista#49 should be ready now. The image regression errors were caused by ubuntu version mismatches. I somehow find myself in these rabbit holes related to a tangential topics lately. I recommend releasing a new version there and then merging this along with a separate PR for pytest-pyvista version bump.