Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example changing mapped scalars #4138

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

banesullivan
Copy link
Member

Users often request how to change the mapped scalars that have already been plotted. Here is a full fledged example with Trame

For #4131

Screen Shot 2023-03-15 at 10 21 53 AM

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #4138 (4531d5b) into main (635052d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4138      +/-   ##
==========================================
- Coverage   95.56%   95.56%   -0.01%     
==========================================
  Files          95       95              
  Lines       20247    20247              
==========================================
- Hits        19350    19349       -1     
- Misses        897      898       +1     

@akaszynski
Copy link
Member

While we can't add this to the gallery, I would like for this to be rendered in our documentation somehow. We could use literalinclude or just a link, but it needs to have a "copy button". Not everyone will go source diving.

@akaszynski
Copy link
Member

Also, is there any way we could test these? Even just a smoke test?

@banesullivan
Copy link
Member Author

I can make a sphinx gallery example of similar nature to this

re: testing... yeah, this is on my to do list to figure out

@akaszynski
Copy link
Member

I'm fine with adding this "as-is", but we should have a follow-up with testing and adding to documentation.

@banesullivan
Copy link
Member Author

Merging this as is and will try to make a proper example demonstrating how to modify the mapper, prop, and lut in more ways

@banesullivan banesullivan merged commit 3e70132 into main Mar 17, 2023
@banesullivan banesullivan deleted the doc/change-mapped-scalars branch March 17, 2023 14:12
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants