Fix/rectangle to polygon

[hippo91]

Overview

This PR address the problem of having a Rectangle function that behaves as a Quadrilateral factory.

resolves #1604

Details

• The Rectangle function has been renamed in Quadrilateral.
• A new Rectangle function has been created.
• It checks that only three points are given. If four points are given it raises a deprecation warning else if more or less than 3 points are given a TypeError is raised.
• The 3 points can be given in arbitrary order but should be different and defines orthogonal vectors otherwise ValueError is raised
• Extensive tests have been added.

[codecov]

Codecov Report

Merging #4145 (fa51c38) into main (d832619) will increase coverage by 0.00%.
The diff coverage is 97.29%.

@@           Coverage Diff           @@
##             main    #4145   +/-   ##
=======================================
  Coverage   95.56%   95.57%           
=======================================
  Files          95       95           
  Lines       20247    20282   +35     
=======================================
+ Hits        19350    19384   +34     
- Misses        897      898    +1     

[MatthewFlamm]

Excellent first PR! Thanks. I have not yet looked through the tests, but some comments to get started.

[akaszynski]

I made a few changes, including aligning it with our way of running tests and checking for warnings/errors.

Thanks for your work!

[hippo91]

@tkoyama010 @akaszynski @adeak @MatthewFlamm thanks for your review.
Is there something more i can do with this PR?

[akaszynski]

@tkoyama010 @akaszynski @adeak @MatthewFlamm thanks for your review. Is there something more i can do with this PR?

We generally wait 24 hours to allow all contributors to say their peace before merging. Expect it merged tomorrow.

Next release is 0.39.0, probably by the end of this month or sooner.

[tkoyama010]

Great first contribution. Thank you!

[akaszynski]

Consider adding a docstring for the test_rectangle_not_orthognal_entries function to provide more context and describe its purpose.

Suggested change

	def test_rectangle_not_orthognal_entries():
	def test_rectangle_not_orthogonal_entries():
	"""Test the error handling when the input points are not orthogonal."""

[akaszynski]

(this is here for testing of another library)