Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GemPy] widget enhancements #415

Merged
merged 11 commits into from
Oct 28, 2019
Merged

[GemPy] widget enhancements #415

merged 11 commits into from
Oct 28, 2019

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Oct 22, 2019

These are improvements from @Leguark's changes in #410 to make the widgets a bit more robust and ready for advanced use in downstream dependencies (namely GemPy). This also greatly improves the testing of the widgets

@Leguark: you can now just pass implicit=False to the add_plane_widget() method and it will handle setting up the simple plane widget with callbacks and all - I'm going to keep the implicit plane widget as the default as it is a bit more user-friendly. Also, this adds a flag, pass_widget to all widget methods that allows you to pass the widget to the callback for advanced usage

Leguark and others added 5 commits October 16, 2019 14:35
- Couple of typos and formatting
- added first draft of plane_widget_simple for orientations
- Sphere widget callback also passes the widget object
@banesullivan banesullivan added the enhancement Changes that enhance the library label Oct 22, 2019
@banesullivan banesullivan self-assigned this Oct 22, 2019
- added plane observer
- Test the call back at the end of the widget definition. This avoids
to make the callback for every single widget when a high number of
widgets are created at the same time
- Added test_callback arg to planes. If the call back is too expensive,
 it is not good to test it every time a (large number of) widget is
 created

 - Minor changes to fix non implicit plane position
@Leguark
Copy link

Leguark commented Oct 23, 2019

Thank you for update this. I had to make a few changes to make it run properly but I do not have the rights to push to this branch directly. Do I make a pull request to this branch or how do you prefer.

Also another problem I found a small bug with add_bounds_axes. I guess it is not worth it a different pull request for that. I am not sure how strict you are with these things

- fixed condition statement involving lists
@banesullivan
Copy link
Member Author

I just sent you an invite to join the org so that you can push to this branch! Feel free to make changes here

As for the bug in the add_bounds_axes, if it’s small, you can add it here - maybe do it as its own commit so I can see what it is

Sent with GitHawk

- added test_callback to sphere_widget

[DOC]

- Added doc strings to test_callback
@banesullivan
Copy link
Member Author

banesullivan commented Oct 27, 2019

Looks good to me. @Leguark, I'm going to merge

@banesullivan banesullivan merged commit 8f8d650 into master Oct 28, 2019
@banesullivan banesullivan deleted the Leguark-gempy_integration branch October 28, 2019 01:50
@banesullivan banesullivan added this to the 0.23.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants