Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable anti-aliasing on cells example and fix doc path for CI #4160

Merged
merged 2 commits into from
Mar 19, 2023

Conversation

beroda
Copy link
Contributor

@beroda beroda commented Mar 19, 2023

Overview

Resolves #4159

@github-actions github-actions bot added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. labels Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #4160 (8667314) into main (e9d9ed7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4160   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          95       95           
  Lines       20282    20282           
=======================================
  Hits        19384    19384           
  Misses        898      898           

@beroda beroda marked this pull request as ready for review March 19, 2023 16:51
@beroda
Copy link
Contributor Author

beroda commented Mar 19, 2023

@banesullivan your suggestion worked. This is what I get from the documentation artifacts:
image

However, for some unknown reason, the job failed. I guess this is not related to this PR as the same occurred for #3643 and might be a github-related issue.

@adeak
Copy link
Member

adeak commented Mar 19, 2023

The build failure's log is

Run mkdir _notebooks
  mkdir _notebooks
  find doc/examples -type f -name '*.ipynb' | cpio -p -d -v _notebooks/
  shell: /usr/bin/bash -e {0}
  env:
    USE_CACHE: true
    PYVISTA_OFF_SCREEN: True
    ALLOW_PLOTTING: true
    SHELLOPTS: errexit:pipefail
    pythonLocation: /opt/hostedtoolcache/Python/3.11.2/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.2/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.2/x64
    Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.2/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.2/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.2/x64/lib
    CACHE_KEY: d5d140c775ff98650123de5571919abf
    PYVISTA_EXAMPLE_DATA_PATH: /home/runner/.cache/pyvista_3
find: ‘doc/examples’: No such file or directory
0 blocks
Error: Process completed with exit code 1.

Looks like some leftovers of the doc/* -> doc/source/* move (cf. #4118). Cc @akaszynski.

@akaszynski
Copy link
Member

Thanks @adeak. Fixed in 8667314.

@akaszynski
Copy link
Member

This will have to be merged soon to unblock other PRs. Recommending merge today as soon as CI passes.

@akaszynski akaszynski changed the title Documentation incorrect image Disable anti-aliasing on cells example and fix doc path for CI Mar 19, 2023
@akaszynski akaszynski merged commit 53a6b6d into pyvista:main Mar 19, 2023
@beroda beroda deleted the fix/documentation_image branch March 19, 2023 22:07
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect image in the online documentation
3 participants