Gitpod no doc build and no prebuild #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4165 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 95 95
Lines 20356 20356
=======================================
Hits 19458 19458
Misses 898 898 |
MatthewFlamm
commented
Mar 21, 2023
tkoyama010
reviewed
Mar 21, 2023
tkoyama010
approved these changes
Mar 21, 2023
|
Thanks for the changes.
If you are interested, the changes here now show a link in the checks overview section that launches a gitpod workspace for the PR branch. If we don't want this, we can put back in the |
banesullivan
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I never set up the project for pre-builds on the Gitpod side and based on some discussion on slack it seems like some more established and larger projects are losing special privelages for free pre-builds. So the prebuild section is removed.
In addition, making the documentation takes too long without the pre-build. It is easier for new users of the documentation is opt-in to build.