Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New example: plotting in spherical coordinates #417

Merged
merged 5 commits into from
Oct 27, 2019

Conversation

dennissergeev
Copy link
Contributor

Following pyvista/pyvista-support#52 and pyvista/pyvista-support#67, I thought it would be useful to have some basic examples of plotting data on a sphere in the gallery.

@banesullivan
Copy link
Member

This is really awesome, thanks @dennissergeev! Also, great job making reusable functions in that example with nice docstrings - I'm wondering if any of those might make sense to add in the utilities module in PyVsita?

@banesullivan banesullivan self-requested a review October 23, 2019 20:16
@banesullivan banesullivan added documentation Anything related to the documentation/website example There's a great example/demo in this thread! labels Oct 23, 2019
@dennissergeev
Copy link
Contributor Author

Thanks @banesullivan!

I'm happy to move these functions to the pyvista/utilities/utilities.py.
Is _cell_bounds() worth adding there too?

Also, there could be a helper function that bundles all of this code. What do you think?

examples/02-plot/spherical.py Outdated Show resolved Hide resolved
examples/02-plot/spherical.py Outdated Show resolved Hide resolved
@banesullivan banesullivan merged commit a2f948d into pyvista:master Oct 27, 2019
@banesullivan banesullivan added this to the 0.23.0 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website example There's a great example/demo in this thread!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants