Fix gallery cache #4173
Merged
Fix gallery cache #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to do an evil no review merge here, so review now or forever hold your peace. |
Codecov Report
@@ Coverage Diff @@
## main #4173 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 95 95
Lines 20356 20356
=======================================
Hits 19458 19458
Misses 898 898 |
tkoyama010
approved these changes
Mar 22, 2023
What is the original source? |
It's said at some weddings: I'm mostly being silly here since I know there's the 24 hour rule, but this is one of those near-trivial fixes that I want to get through to reduce our build time from ~40 to ~20 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I neglected to fix our gallery cache path in #4118 and it's causing our documentation builds to take forever.