Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trame-vtk maintenance #4183

Merged
merged 5 commits into from
Mar 26, 2023
Merged

trame-vtk maintenance #4183

merged 5 commits into from
Mar 26, 2023

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Mar 24, 2023

Maintenance PR to leverage the latest features and bug fixes from trame-vtk.

This is waiting on Kitware/trame-vtk#31

resolves #4020

@github-actions github-actions bot added dependencies Pull requests that update a dependency file docker maintenance Low-impact maintenance activity labels Mar 24, 2023
@banesullivan banesullivan reopened this Mar 24, 2023
pyvista/trame/jupyter.py Outdated Show resolved Hide resolved
@banesullivan banesullivan marked this pull request as ready for review March 24, 2023 17:02
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #4183 (c39e200) into main (831fb73) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4183      +/-   ##
==========================================
- Coverage   95.59%   95.59%   -0.01%     
==========================================
  Files          95       95              
  Lines       20333    20323      -10     
==========================================
- Hits        19438    19428      -10     
  Misses        895      895              

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

@tkoyama010 tkoyama010 merged commit 1fa12fd into main Mar 26, 2023
@tkoyama010 tkoyama010 deleted the maint/bump-trame-vtk branch March 26, 2023 01:52
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subplot cannot zoom in
3 participants