-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trims trailing whitespace in pre-commit-hooks #4211
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4211 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 97 97
Lines 20687 20687
=======================================
Hits 19813 19813
Misses 874 874 |
We need to exclude vtk and ply files. |
@adeak Should I add a commit to blame ignore, even though this change is slight? |
Thanks for the ping :) Since the diff is small and .pre-commit-config.yaml is changed, I think we shoukd keep this in the blame. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @adeak, this does not need to be excluded from the blame.
LGTM, thanks @tkoyama010
Overview
Add Trims trailing whitespace in pre-commit-hooks.
Details