Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trims trailing whitespace in pre-commit-hooks #4211

Merged
merged 8 commits into from
Apr 3, 2023

Conversation

tkoyama010
Copy link
Member

@tkoyama010 tkoyama010 commented Mar 31, 2023

Overview

Add Trims trailing whitespace in pre-commit-hooks.

  • Discuss adding a commit to blame ignore.

Details

  • None

@github-actions github-actions bot added documentation Anything related to the documentation/website maintenance Low-impact maintenance activity labels Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #4211 (e5042e8) into main (f49378e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4211   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          97       97           
  Lines       20687    20687           
=======================================
  Hits        19813    19813           
  Misses        874      874           

@tkoyama010
Copy link
Member Author

We need to exclude vtk and ply files.

@tkoyama010 tkoyama010 marked this pull request as ready for review April 3, 2023 00:48
@tkoyama010
Copy link
Member Author

@adeak Should I add a commit to blame ignore, even though this change is slight?

@adeak
Copy link
Member

adeak commented Apr 3, 2023

Thanks for the ping :) Since the diff is small and .pre-commit-config.yaml is changed, I think we shoukd keep this in the blame.

Copy link
Member

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @adeak, this does not need to be excluded from the blame.

LGTM, thanks @tkoyama010

@akaszynski akaszynski merged commit 1f28aad into main Apr 3, 2023
21 checks passed
@akaszynski akaszynski deleted the maint/add-trailing-whitespace branch April 3, 2023 14:01
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants