Add 'connected' argument to 'Plotter.add_lines' to create a series of connected lines

[p-j-smith]

Overview

Add support for using Plotter.add_lines to create a series of connected lines from an array of points, i.e. the behaviour of this function prior to #3687

resolves #4065

Details

• add a connected argument to Plotter.add_lines. If connected=True, the points passed to Plotter.add_lines will be taken to form a series of connected lines. The default is False to maintain the current behaviour of the function

• add a test to check the correct number of line segments is created when setting connected=True

[codecov]

Codecov Report

Merging #4214 (b9686f1) into main (f49378e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4214   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          97       97           
  Lines       20687    20687           
=======================================
  Hits        19813    19813           
  Misses        874      874           

[adeak]

@p-j-smith although we don't have an official policy about this, I recommend merging instead of rebasing and force pushing on PRs unless you have a strong opinion of your own in this regard :) We use squash merge so the local history on PRs is not a concern, and rebasing runs the risk of losing commits pushed by others (not a concern in your case probably, because you know what you're doing) and not being able to use the "changes since you last viewed" button on github that helps reviewing.

[adeak]

Thanks for the contribution @p-j-smith. One comment, works for me with or without that.

[p-j-smith]

I recommend merging instead of rebasing and force pushing on PRs

sorry about that! I do usually rebase and force push but I'm happy to merge in future pyvista prs

[tkoyama010]

@p-j-smith LGTM. Thanks for this. It is perfect!

[p-j-smith]

Thanks for the fast reviews @adeak and @tkoyama010 ! Would one of you mind merging as I'm not authorised? Thanks!

[tkoyama010]

We usually check that there are no objections 24 hours after the initial approval is given. This is to give accounts in all time zones a fair opportunity to comment. Already, I am going to merge because it has been 24 hours since the first approval.