Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use setup-headless for pyvistaqt #4241

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Conversation

larsoner
Copy link
Contributor

@larsoner larsoner commented Apr 6, 2023

Might as well use setup-headless-display-action for pyvistaqt integration. Also remove --depth=1 which might (?) be necessary for pyvista/pyvistaqt#356

@github-actions github-actions bot added the maintenance Low-impact maintenance activity label Apr 6, 2023
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #4241 (197d6f8) into main (e71be93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4241   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          97       97           
  Lines       20694    20694           
=======================================
  Hits        19820    19820           
  Misses        874      874           

Copy link
Member

@banesullivan banesullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the follow up here

@akaszynski akaszynski merged commit f420e59 into pyvista:main Apr 9, 2023
21 checks passed
@larsoner larsoner deleted the pyvistaqt branch April 9, 2023 16:19
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants