Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tubes example #4248

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Fix tubes example #4248

merged 3 commits into from
Apr 11, 2023

Conversation

akaszynski
Copy link
Member

Fix the Plot CFD Data example by incorporating the following suggestions from @MatthewFlamm:

  • Use the inlet with streamlines_from_source.
  • Return the entire MultiBlock.
  • sample rather than interpolate

@github-actions github-actions bot added documentation Anything related to the documentation/website bug Uh-oh! Something isn't working as expected. labels Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited

Codecov Report

Merging #4248 (1d617cd) into main (dd44661) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4248   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          97       97           
  Lines       20695    20695           
=======================================
  Hits        19819    19819           
  Misses        876      876

@tkoyama010 tkoyama010 mentioned this pull request Apr 10, 2023
Merged
MatthewFlamm
MatthewFlamm reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few stylistic comments, but otherwise LGTM

examples/99-advanced/openfoam-tubes.py Outdated Show resolved Hide resolved
examples/99-advanced/openfoam-tubes.py Outdated Show resolved Hide resolved
@akaszynski akaszynski merged commit 0d7a463 into main Apr 11, 2023
21 checks passed
@akaszynski akaszynski deleted the fix/tube-example branch April 11, 2023 05:45
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewFlamm MatthewFlamm MatthewFlamm approved these changes

Assignees
No one assigned
Labels
bug Uh-oh! Something isn't working as expected. documentation Anything related to the documentation/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akaszynski @MatthewFlamm