Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple aero bracket #4258

Merged
merged 2 commits into from
Apr 15, 2023
Merged

Add simple aero bracket #4258

merged 2 commits into from
Apr 15, 2023

Conversation

akaszynski
Copy link
Member

@akaszynski akaszynski commented Apr 11, 2023

Add the finite element solution of an aero bracket.

Data generated from public SimScale examples at SimScale Project Library - Turbo.

Licensing for this dataset is granted to freely and without restriction reproduce, distribute, publish according to the SimScale Terms and Conditions.

>>> from pyvista import examples
>>> dataset = examples.download_aero_bracket()
>>> cpos = [
...     (-0.0503, 0.132, -0.179),
...     (0.0505, 0.0185, -0.00201),
...     (0.275, 0.872, 0.405),
... ]
>>> dataset.plot(
...     smooth_shading=True,
...     split_sharp_edges=True,
...     scalars='von Mises stress',
...     cmap='bwr',
...     cpos=cpos,
... )

image

@github-actions github-actions bot added the enhancement Changes that enhance the library label Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4258 (bcbf908) into main (05b8e4a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4258   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          97       97           
  Lines       20695    20695           
=======================================
  Hits        19819    19819           
  Misses        876      876           

@tkoyama010
Copy link
Member

@akaszynski
Thank you for adding the simscale example. This is very useful to validate the FEA software at my hand. simscale examples may be added in the future, so I would like to suggest that you put together an example, as I did with the planet. How about creating a module using the name simscale?

@akaszynski
Copy link
Member Author

@akaszynski Thank you for adding the simscale example. This is very useful to validate the FEA software at my hand. simscale examples may be added in the future, so I would like to suggest that you put together an example, as I did with the planet. How about creating a module using the name simscale?

I think the planets module is a great way of organizing the examples! However, I'm opposed to including module that is directly linked to a specific application or software. For example, we can include Ansys, SimScale, or OnScale examples, but we shouldn't tie ourselves to a specific CAE entity.

What we can do instead is add a FEA or FVM module to start collecting all these examples together. We're indeed starting to accumulate quite a few and it will be helpful to have some organization to this moving forward.

Copy link
Member

@tkoyama010 tkoyama010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akaszynski Thanks for your thoughts. I'd organize, but that's another PR.

@tkoyama010 tkoyama010 merged commit b12e45a into main Apr 15, 2023
21 checks passed
@tkoyama010 tkoyama010 deleted the feat/add-aero-bracket branch April 15, 2023 23:43
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Changes that enhance the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants