-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] Remove codecov from requirements #4269
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4269 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 97 97
Lines 20754 20754
=======================================
Hits 19878 19878
Misses 876 876 |
I think if we can fix this today, we should fix this now before we forget about codecov. I'm fairly certain that it's as easy as using: |
It seems that we already set GitHubActions. Maybe all we have to do is remove the package (I will investigate this in more detail later.). pyvista/.github/workflows/testing-and-deployment.yml Lines 207 to 208 in f765afc
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks needed for our CI to work again.
@MatthewFlamm Thanks. We also need to merge pyvista/pyvistaqt#360 . Please approve it too if it is OK. |
Looks like we already have this implemented in pyvista/.github/workflows/testing-and-deployment.yml Lines 207 to 208 in 75961b6
In this PR we've removed |
Done. Integration tests all passing here. Thanks for everyone's work resolving this and sorry to be slow on the uptake. It's been a long week. |
Overview
codecov has deprecated pypi and requires an intention to GitHubActions. We will work on the migration to GitHubActions in the future, but first please merge this PR to fix the CI error.
Relevant Migration Article: https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader
With example repo https://github.com/codecov/example-python/
Details