Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Remove codecov from requirements #4269

Merged
merged 4 commits into from
Apr 14, 2023

Conversation

tkoyama010
Copy link
Member

Overview

codecov has deprecated pypi and requires an intention to GitHubActions. We will work on the migration to GitHubActions in the future, but first please merge this PR to fix the CI error.

Relevant Migration Article: https://docs.codecov.com/docs/deprecated-uploader-migration-guide#python-uploader
With example repo https://github.com/codecov/example-python/

Details

  • None

@github-actions github-actions bot added dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity labels Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #4269 (39aa772) into main (477c3f4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4269   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files          97       97           
  Lines       20754    20754           
=======================================
  Hits        19878    19878           
  Misses        876      876           

@akaszynski
Copy link
Member

I think if we can fix this today, we should fix this now before we forget about codecov.

I'm fairly certain that it's as easy as using:

https://github.com/codecov/codecov-action

@tkoyama010 tkoyama010 marked this pull request as draft April 13, 2023 04:08
@tkoyama010
Copy link
Member Author

It seems that we already set GitHubActions. Maybe all we have to do is remove the package (I will investigate this in more detail later.).

- uses: codecov/codecov-action@v3
name: 'Upload coverage to CodeCov'

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks needed for our CI to work again.

@tkoyama010
Copy link
Member Author

@MatthewFlamm Thanks. We also need to merge pyvista/pyvistaqt#360 . Please approve it too if it is OK.

@akaszynski
Copy link
Member

I think if we can fix this today, we should fix this now before we forget about codecov.

I'm fairly certain that it's as easy as using:

https://github.com/codecov/codecov-action

Looks like we already have this implemented in

- uses: codecov/codecov-action@v3
name: 'Upload coverage to CodeCov'

In this PR we've removed codecov from our requirements and it still works. See:
https://app.codecov.io/gh/pyvista/pyvista/pull/4269/commits

@akaszynski akaszynski marked this pull request as ready for review April 14, 2023 17:30
@akaszynski
Copy link
Member

@MatthewFlamm Thanks. We also need to merge pyvista/pyvistaqt#360 . Please approve it too if it is OK.

Done. Integration tests all passing here. Thanks for everyone's work resolving this and sorry to be slow on the uptake. It's been a long week.

@akaszynski akaszynski merged commit b8a4edf into main Apr 14, 2023
21 checks passed
@akaszynski akaszynski deleted the maint/remove-codecov-from-requirements branch April 14, 2023 17:39
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance Low-impact maintenance activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants