Remove flask examples #4299
Merged
Remove flask examples #4299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #4299 +/- ##
=======================================
Coverage 95.77% 95.77%
=======================================
Files 97 97
Lines 20755 20755
=======================================
Hits 19879 19879
Misses 876 876 |
tkoyama010
approved these changes
Apr 18, 2023
|
Absolutely agree with this. While I think it might be useful in some edge case to save an image offline, I think that sort of workflow is quite straightforward and we don't need to include it out of the concern of confusing the user. |
I have learned a bit about Trame and this may be feasible with Trame. |
|
It is possible with trame 😉 I just need to expose it in the PyVista view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flask examples were rough proof of concept when they were created. They do not scale and are light years behind what's possible with Trame. Considering the adoption and growth we have seen with PyVista+Trame, I think we should outright remove the flask examples as they only mislead and confuse users (as pointed out in #4297 (reply in thread))