-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the edit this page link #4320
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4320 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 97 97
Lines 20762 20774 +12
=======================================
+ Hits 19886 19898 +12
Misses 876 876 |
Thanks for the ping, @akaszynski. This is something we need to stream up to our repositories. |
To avoid having the search option there are two possibilities:
The whole thing needs careful thinking. It should be possible. But it needs more than what I did in ansys/pymapdl#2012 Temporary alternative, we could maybe link the search to provide directly the first result though. Github search API should provide information enough to directly link the first result of the search. -- edit -- |
I think the "edit this page" button should always jump to a github edit page, regardless of if it jumps right to the function or not (which is not available within GitHub's API). Sending them to a search function means that we'll have different behavior depending on if it's an autosummary or not. Fully agree that it's not a perfect solution, but "edit" seems like it should go to an "edit" page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM!
Haven't given this a thorough review but all looks right to me and agree with conclusions of previous discussions
Inspired by ansys/pymapdl#2012, this PR fixes the "Edit this page" button, which is currently overall because of the move from "doc/" to "doc/source".
Moreover, it also provides correct links for our:
These were broken even before the documentation move.
@germa89 and @jorgepiloto, I suggest that we implement it this way, it's guarenteed to get to the right source file location rather than implementing a search in GitHub.