Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable anti-aliasing on openfoam cooling example #4321

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

akaszynski
Copy link
Member

Disable anti-aliasing on openfoam cooling example to see if this fixes the missing volumetric actor.

@github-actions github-actions bot added the documentation Anything related to the documentation/website label Apr 24, 2023
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #4321 (c67885b) into main (236b02f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4321   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files          97       97           
  Lines       20773    20773           
=======================================
  Hits        19897    19897           
  Misses        876      876           

@akaszynski
Copy link
Member Author

@MatthewFlamm, this is to address your issue raised in the PR. This has been fixed in this PR and I've verified it works in the doc build:
image

Copy link
Contributor

@MatthewFlamm MatthewFlamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaszynski akaszynski merged commit 32ce92e into main Apr 26, 2023
25 checks passed
@akaszynski akaszynski deleted the docs/fix-cooling-example-volume branch April 26, 2023 14:51
@akaszynski akaszynski mentioned this pull request Apr 30, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants