Fix linkchecker workflow and make file
#4327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
germa89
changed the title
linkchecker workflow and make filelinkchecker workflow and make file
germa89
changed the title
linkchecker workflow and make fileinkchecker workflow and make file
germa89
changed the title
inkchecker workflow and make filelinkchecker workflow and make file
|
Good catch. Integration checks with MNE will be broken for a bit. Will merge once this has been fixed. Agree with ' --> " for consistency with our extensions, but just FYI, we don't enforce single vs. double quotes. |
Codecov Report
@@ Coverage Diff @@
## main #4327 +/- ##
==========================================
- Coverage 95.78% 93.65% -2.14%
==========================================
Files 97 97
Lines 20773 20773
==========================================
- Hits 19897 19454 -443
- Misses 876 1319 +443 |
akaszynski
reviewed
Apr 24, 2023
akaszynski
reviewed
Apr 24, 2023
akaszynski
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow
linkcheckeris broken:https://github.com/pyvista/pyvista/actions/workflows/linkcheck.yml
This PR should fix it. Some double check will be appreciated.