Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot output of docstring #4383

Merged
merged 2 commits into from
May 5, 2023
Merged

Fix plot output of docstring #4383

merged 2 commits into from
May 5, 2023

Conversation

tkoyama010
Copy link
Member

Overview

The plotting output for the newly added align method was not displayed, so I fixed it.

Main This PR
image image

Follow up of #4361

Details

  • It is better to be able to output the plot without changing the docstring, but I could not find the cause. Ideas are welcome.

@github-actions github-actions bot added the documentation Anything related to the documentation/website label May 4, 2023
@tkoyama010 tkoyama010 marked this pull request as ready for review May 4, 2023 09:07
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #4383 (467cf53) into main (d9dd94e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4383   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          97       97           
  Lines       20863    20863           
=======================================
  Hits        19991    19991           
  Misses        872      872           

banesullivan
banesullivan previously approved these changes May 4, 2023
@akaszynski akaszynski enabled auto-merge (squash) May 5, 2023 00:47
@akaszynski akaszynski merged commit efc6e80 into main May 5, 2023
24 checks passed
@akaszynski akaszynski deleted the doc/fix-docstring-output branch May 5, 2023 01:19
@MatthewFlamm
Copy link
Contributor

MatthewFlamm commented May 10, 2023

I'm seeing this behavior all over the docs, i.e. a final plot.show() doesn't render an image. Do we have to fix this by having another line afterwards like in this PR?

Edit: My apologies. It is too confusing to continue the conversation here. I will start an issue. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Anything related to the documentation/website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants