Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass all errors with panel on import #440

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Pass all errors with panel on import #440

merged 1 commit into from
Nov 11, 2019

Conversation

banesullivan
Copy link
Member

@banesullivan banesullivan commented Nov 8, 2019

Folks are reporting issues with panel so this will allow them to still use PyVista with a broken install of panel

ping @prisae

@prisae
Copy link
Member

prisae commented Nov 8, 2019

Plain except might raise some flake8-flags. But I think in this case it is justified.

@banesullivan
Copy link
Member Author

I’m not worried about flake8 issues... we have a number of bare excepts that should probably be cleaned up down the road. This one is justified though.

Sent with GitHawk

@banesullivan banesullivan added this to the 0.23.0 milestone Nov 8, 2019
@banesullivan banesullivan merged commit 606b4f9 into master Nov 11, 2019
@banesullivan banesullivan deleted the panel branch November 19, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants