Fix random behavior of CylinderStructured #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banesullivan
commented
Nov 8, 2019
prisae
approved these changes
Nov 12, 2019
imsodin
reviewed
Nov 12, 2019
There was a problem hiding this comment.
Changes look good (except for a nit and what @prisae wrote). However does it actually resolve #439? They ask for being able to specify a second direction for the seed point. This PR changes that direction from a random one to the projection of the z-axis to the plane vertical to the cylinder axis. That might be enough for their purposes, but is not exactly the same thing.
Co-Authored-By: Simon Frei <freisim93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #439
This should fix the random location of the seed point by not arbitrarily rotating the mesh to the given direction vector.
Someone may need to check my vector math